[pve-devel] [RFC PATCH 1/2] do not use PVE::API2 in spiceproxy.pm

Dietmar Maurer dietmar at proxmox.com
Wed Aug 9 18:17:20 CEST 2017


Looks quite strange to me, because PVE::HTTPServer calls:

 PVE::API2->find_handler

so we should use PVE::API2 in PVE::HTTPServer?

Not sure why it works without??

> On August 9, 2017 at 2:08 PM Dominik Csapak <d.csapak at proxmox.com> wrote:
> 
> 
> we do not need it there and withouth this we save ~30MB memory for
> this daemon and its workers
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/Service/spiceproxy.pm | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/PVE/Service/spiceproxy.pm b/PVE/Service/spiceproxy.pm
> index 20fd5b24..22a501b0 100755
> --- a/PVE/Service/spiceproxy.pm
> +++ b/PVE/Service/spiceproxy.pm
> @@ -10,7 +10,6 @@ use warnings;
>  use PVE::SafeSyslog;
>  use PVE::Daemon;
>  use PVE::API2Tools;
> -use PVE::API2;
>  use PVE::HTTPServer;
>  
>  use base qw(PVE::Daemon);
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



More information about the pve-devel mailing list