[pve-devel] [PATCH manager] build: ensure REPOID has a length of 8

Fabian Grünbichler f.gruenbichler at proxmox.com
Wed Aug 9 11:42:32 CEST 2017

because unlike the git-rev-parse man page says, the default
length is actually calculated based on the number of packed
objects in the clone of the repository.

we don't want this to depend on the build environment and
how the repository was cloned there, so fix a length of 8
for now.

Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
note: this caused recent builds of pve-manager to have 7-digit
pve-manager REPOIDs, but it seems nobody noticed or cared?

 PVE/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Makefile b/PVE/Makefile
index 33c110be..5cc19904 100644
--- a/PVE/Makefile
+++ b/PVE/Makefile
@@ -14,7 +14,7 @@ PERLSOURCE = 			\
 all: pvecfg.pm ${SUBDIRS}
-REPOID=$(shell git rev-parse --short HEAD)
+REPOID=$(shell git rev-parse --short=8 HEAD)
 pvecfg.pm: pvecfg.pm.in
 	sed -e s/@VERSION@/${VERSION}/ -e s/@PACKAGERELEASE@/${PACKAGERELEASE}/ -e s/@PACKAGE@/${PACKAGE}/ -e s/@REPOID@/${REPOID}/ $< >$@.tmp

More information about the pve-devel mailing list