[pve-devel] applied: [PATCH cluster] fix #1472: fix rrd file path

Wolfgang Bumiller w.bumiller at proxmox.com
Tue Aug 8 08:47:39 CEST 2017


applied

On Mon, Aug 07, 2017 at 04:04:24PM +0200, Dominik Csapak wrote:
> upstream rrd-tools changed the syntax for the perl binding,
> we now have to supply '-' as the path despite what the documentation
> says (it says to supply an empty path, what we did)

Apparently "-" has always worked (the code used to turn "-" into "",
that part's gone now... "-" is more consistent with the rest of the
world anyway I suppose.)

> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  data/PVE/Cluster.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
> index 38c5fdb..2f46754 100644
> --- a/data/PVE/Cluster.pm
> +++ b/data/PVE/Cluster.pm
> @@ -736,7 +736,7 @@ sub create_rrd_graph {
>      push @args, '--full-size-mode';
>  
>      # we do not really store data into the file
> -    my $res = RRDs::graphv('', @args);
> +    my $res = RRDs::graphv('-', @args);
>  
>      my $err = RRDs::error;
>      die "RRD error: $err\n" if $err;
> -- 
> 2.11.0



More information about the pve-devel mailing list