[pve-devel] [PATCH qemu-server 03/10] qm mtunnel: add tunnel version

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Aug 4 11:53:27 CEST 2017


On 08/04/2017 10:55 AM, Fabian Gr├╝nbichler wrote:
> to allow detection of supported features/commands for these
> and future mtunnel changes.
> 
> Signed-off-by: Fabian Gr├╝nbichler <f.gruenbichler at proxmox.com>
> ---
>   PVE/CLI/qm.pm | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
> index e192153..77fd983 100755
> --- a/PVE/CLI/qm.pm
> +++ b/PVE/CLI/qm.pm
> @@ -268,6 +268,9 @@ __PACKAGE__->register_method ({
>   	print "tunnel online\n";
>   	*STDOUT->flush();
>   
> +	print "ver 1.0\n";

nitpick: I'd just use a integer, this is internal versioning, makes the
regex in the next patch a bit easier and I see no real value in using 
float here.


> +	*STDOUT->flush();
> +
>   	while (my $line = <>) {
>   	    chomp $line;
>   	    last if $line =~ m/^quit$/;
> 





More information about the pve-devel mailing list