[pve-devel] [PATCH] ceph : use jemalloc for build

[Fabian Grünbichler]

On Wed, Apr 19, 2017 at 05:14:10PM +0200, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  patches/0007-use-jemmaloc-for-build.patch | 47 +++++++++++++++++++++++++++++++
>  patches/series                            |  1 +
>  2 files changed, 48 insertions(+)
>  create mode 100644 patches/0007-use-jemmaloc-for-build.patch
> 
> diff --git a/patches/0007-use-jemmaloc-for-build.patch b/patches/0007-use-jemmaloc-for-build.patch
> new file mode 100644
> index 0000000..55117ae
> --- /dev/null
> +++ b/patches/0007-use-jemmaloc-for-build.patch
> @@ -0,0 +1,47 @@
> +From 7946e8c1695a8556a24eae2768c2ba2b581e50df Mon Sep 17 00:00:00 2001
> +From: Alexandre Derumier <aderumier at odiso.com>
> +Date: Tue, 18 Apr 2017 15:48:30 +0200
> +Subject: [PATCH] use jemmaloc for build
> +
> +Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> +---
> + control | 3 ++-
> + rules   | 1 +
> + 2 files changed, 3 insertions(+), 1 deletion(-)
> +
> +diff --git a/control b/control
> +index 8974d32..e23d4d6 100644
> +--- a/debian/control
> ++++ b/debian/control
> +@@ -7,6 +7,7 @@ Vcs-Browser: https://github.com/ceph/ceph
> + Maintainer: Ceph Maintainers <ceph-maintainers at lists.ceph.com>
> + Uploaders: Ken Dreyer <kdreyer at redhat.com>,
> +            Alfredo Deza <adeza at redhat.com>
> ++Build-Conflicts: libgoogle-perftools-dev [i386 amd64 arm64]

I don't really like this, and AFAICT it is not needed - see below.

> + Build-Depends: bc,
> +                btrfs-tools,
> + 	       cmake,
> +@@ -40,7 +41,7 @@ Build-Depends: bc,
> +                libexpat1-dev,
> +                libfcgi-dev,
> +                libfuse-dev,
> +-               libgoogle-perftools-dev [i386 amd64 arm64],
> ++	       libjemalloc-dev,
> + 		libibverbs-dev,
> +                libkeyutils-dev,
> +                libleveldb-dev,
> +diff --git a/rules b/rules
> +index 93158d2..1b46825 100755
> +--- a/debian/rules
> ++++ b/debian/rules
> +@@ -12,6 +12,7 @@ extraopts += -DCMAKE_INSTALL_LIBDIR=/usr/lib
> + extraopts += -DCMAKE_INSTALL_LIBEXECDIR=/usr/lib
> + extraopts += -DCMAKE_INSTALL_SYSCONFDIR=/etc
> + extraopts += -DWITH_SYSTEM_BOOST=ON
> ++extraopts += -DWITH_JEMALLOC=ON

this flag is only for rocksdb, and only for the windows build?

I propose "-DALLOCATOR=jemalloc" instead - what do you think?

> + 
> + ifeq ($(DEB_HOST_ARCH), armel)
> +   # armel supports ARMv4t or above instructions sets.
> +-- 
> +2.1.4
> +
> diff --git a/patches/series b/patches/series
> index e1de413..463b39c 100644
> --- a/patches/series
> +++ b/patches/series
> @@ -4,3 +4,4 @@
>  0004-enable-systemd-targets-by-default.patch
>  0005-use-sockaddr_storage-for-IPv6-compat.patch
>  0006-Revert-debian-drop-boost-build-dependencies.patch
> +0007-use-jemmaloc-for-build.patch
> -- 
> 2.11.0