[pve-devel] [PATCH V2 pve-ha-manager] Fix shutdown order of ceph daemons.

[Fabian Grünbichler]

On Wed, Apr 26, 2017 at 02:19:00PM +0200, Thomas Lamprecht wrote:
> On 04/26/2017 01:17 PM, Wolfgang Link wrote:
> > It is important that storages stop after pve-ha-lrm.
> > 
> > If the storages  stops to early the vm loses disks
> > and can not shutdown.
> > 
> > This can ends in fencing the node.
> > ---
> >   debian/pve-ha-lrm.service | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/debian/pve-ha-lrm.service b/debian/pve-ha-lrm.service
> > index 3dc2ebc..8da0eb4 100644
> > --- a/debian/pve-ha-lrm.service
> > +++ b/debian/pve-ha-lrm.service
> > @@ -6,6 +6,7 @@ Wants=watchdog-mux.service
> >   Wants=pvedaemon.service
> >   Wants=pve-ha-crm.service
> >   Wants=lxc.service
> > +After=pve-storage.target
> I'd also add the
> 
> Wants=pve-storage.target
> 
> To ensure that all storages are up when the HA stack begins to start
> VMs/CTs?

But that is specifically not what "Wants" gives you.. Wants just says:
please start this unit if I am started, but if it fails or is not even
there at all, I don't care.

You could have the stronger variant of Wants, which is "Requires":
start this unit if I am started, if it fails or is not there, don't
start me, and if it later gets stopped/fails, also stop me. This is
definitely not desired here - otherwise the HA manager would be stopped
when a user manually unmounts an NFS share ;)

"After" already ensures that if pve-storage.target is enabled,
pve-ha-lrm will be started only once it is reached. IMHO it might still
make sense to add the Wants, just for the rare case where pveproxy is
explicitly disabled (/broken) while pve-ha-lrm is not. Additionally, it
might make sense to let pve-storage be pulled in by the multi-user
target and enable it upon installation?

> 
> Else acked by me.
> 
> >   After=pve-ha-crm.service
> >   After=pve-cluster.service
> >   After=corosync.service
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel