[pve-devel] [PATCH] qemu-server : scsi_fmt : add rerror
Wolfgang Bumiller
w.bumiller at proxmox.com
Wed Apr 19 12:49:45 CEST 2017
Are all values supported? I thought only the default was supported
there. (Although that may have also been the case for werror).
If it works, though, better just remove %rerror_fmt and move its
contents into %drivedesc_base to where werror is already, as it is then
part of every drive format hash I think?
On Tue, Apr 18, 2017 at 11:33:17PM +0200, Alexandre Derumier wrote:
> seem that we forgot to add rerror to scsi disk. (werror is already present)
>
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
> PVE/QemuServer.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 6865d60..80da44f 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -877,6 +877,7 @@ my $idedesc = {
> PVE::JSONSchema::register_standard_option("pve-qm-ide", $idedesc);
>
> my $scsi_fmt = {
> + %rerror_fmt,
Something inside me compels me to complain about the fact that with
every other hash starting with %drivedesc_base, this really should be
at least one line lower ;-).
> %drivedesc_base,
> %iothread_fmt,
> %queues_fmt,
> --
> 2.11.0
More information about the pve-devel
mailing list