[pve-devel] applied: [PATCH qemu-server] don't compare booleans

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Apr 3 15:01:37 CEST 2017


a) because perl isn't THAT bad of a language that you'd need
to do this and b) because JSON::XS version 2.90 "dropped"
this "feature"
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 4c9c88c..6865d60 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6020,7 +6020,7 @@ sub qemu_drive_mirror_monitor {
 		    print "$job: transferred: $transferred bytes remaining: $remaining bytes total: $total bytes progression: $percent % busy: $busy ready: $ready \n";
 		}
 
-		$readycounter++ if $running_mirror_jobs->{$job}->{ready} eq 'true';
+		$readycounter++ if $running_mirror_jobs->{$job}->{ready};
 	    }
 
 	    last if scalar(keys %$jobs) == 0;
-- 
2.11.0





More information about the pve-devel mailing list