[pve-devel] [PATCH cluster 1/4] add migration format to datacenter config

[Thomas Lamprecht]

On 10/28/2016 12:20 PM, Fabian Grünbichler wrote:
>>> wouldn't it make more sense to not allow both options (and error out or
>>> at least warn)?
>> Error-ing out on each datacenter config read seems not that ideal to me.
>> As I can directly map the old setting to the new (i.e. a name change of the
>> property only) doing this seems not that bad for me.
>>
>> How about adding similar check to the write parser so that it gets rewritten
>> to the new format if the old is set?
>>
> the problem is, what if the user specifies two conflicting values? I
> think at least in that case a warn or error is appropriate.

I simply prefer the newer one, if the user himself opened the file and 
added another value
  which conflicts with his old settings (should be rarely the case) and 
let the old there he probably
  wants the new behaviour as this is the last one set :)

A warning may be good though.

> rewriting existing (non-conflicting) config files to the new schema
> makes sense though.
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel