[pve-devel] [PATCH 1/7] split qemu_drive_mirror_monitor from qemu_drive_mirror.

[Alexandre DERUMIER]

>>Doesn't make sense given the patch snippet: 

Ok, sorry, I think I have read an old git code in my sources.
I'll fix that

----- Mail original -----
De: "Wolfgang Bumiller" <w.bumiller at proxmox.com>
À: "Alexandre Derumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Jeudi 20 Octobre 2016 12:51:42
Objet: Re: [pve-devel] [PATCH 1/7] split qemu_drive_mirror_monitor from qemu_drive_mirror.

On Thu, Oct 20, 2016 at 10:57:22AM +0200, Alexandre DERUMIER wrote: 
> >> + vm_mon_cmd($vmid, "drive-mirror", %$opts); 
> 
> >>This is now outside an eval block which otherwise had a cancel_job() 
> >>error case. (Note that it looks like the error cases of vm_mon_cmd() 
> >>*should* not need a cancel_job() call, but it's better to be safe than 
> >>sorry. 
> 
> This was already outside the eval bloc 
> 
> previous code: 
> 
> print "drive mirror is starting : this step can take some minutes/hours, depend of disk size and storage speed\n"; 
> 
> vm_mon_cmd($vmid, "drive-mirror", %$opts); 
> eval { 
> while (1) { 
> my $stats = vm_mon_cmd($vmid, "query-block-jobs"); 

Doesn't make sense given the patch snippet: 

> eval { 
> - vm_mon_cmd($vmid, "drive-mirror", %$opts); 
> while (1) { 

The vm_mon_cmd() call was not indented correctly though ;-) 

https://git.proxmox.com/?p=qemu-server.git;a=blob;f=PVE/QemuServer.pm;h=728110fbaf7aa89f02f8947d0e132f07e4ed808d;hb=refs/heads/master#l5831