[pve-devel] [PATCH v2 common] SectionConfig: always write out explicitly set booleans
Wolfgang Bumiller
w.bumiller at proxmox.com
Wed Oct 12 11:35:19 CEST 2016
Because when only writing the ones which are true we're
breaking the ones which default to true (like the mkdir
option on directory storages, where we need a false value
to be written out explicitly).
---
Changes to v1:
Only write out explicitly set values. This is nicer as values which are
left untouched now mean "use the default" again.
src/PVE/SectionConfig.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm
index 3030f60..a6301e2 100644
--- a/src/PVE/SectionConfig.pm
+++ b/src/PVE/SectionConfig.pm
@@ -400,7 +400,8 @@ my $format_config_line = sub {
if ($key =~ m/[\n\r]/) || ($value =~ m/[\n\r]/);
if ($ct eq 'boolean') {
- return $value ? "\t$key\n" : '';
+ return "\t$key " . ($value ? 1 : 0) . "\n"
+ if defined($value);
} else {
return "\t$key $value\n" if "$value" ne '';
}
--
2.1.4
More information about the pve-devel
mailing list