[pve-devel] Applied: Re: [PATCH] numaX : use cpus option multiple time if cpulist

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Oct 10 10:21:00 CEST 2016


Applied, but I'm curious: qemu does have code to handle double-commas,
but it seems to be incomplete since ',,' doesn't work either.
Not that it would make much of a difference since we only used one comma
anyway ;-)

On Mon, Oct 10, 2016 at 09:36:55AM +0200, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  PVE/QemuServer/Memory.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm
> index 087584b..0e4c830 100644
> --- a/PVE/QemuServer/Memory.pm
> +++ b/PVE/QemuServer/Memory.pm
> @@ -256,7 +256,7 @@ sub config {
>  	    # cpus
>  	    my $cpulists = $numa->{cpus};
>  	    die "missing NUMA node$i cpus\n" if !defined($cpulists);
> -	    my $cpus = join(',', map {
> +	    my $cpus = join(',cpus=', map {
>  		my ($start, $end) = @$_;
>  		defined($end) ? "$start-$end" : $start
>  	    } @$cpulists);
> -- 
> 2.1.4
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




More information about the pve-devel mailing list