[pve-devel] [PATCH manager v2 1/2] Add global regexp to match bus entry in a VM config

[Dietmar Maurer]

> On October 6, 2016 at 8:00 AM Dietmar Maurer <dietmar at proxmox.com> wrote:
> 
> 
> 
> 
> > On October 5, 2016 at 2:24 PM Emmanuel Kasper <e.kasper at proxmox.com> wrote:
> > 
> > 
> > ---
> >  www/manager6/Utils.js              | 2 ++
> >  www/manager6/qemu/BootOrderEdit.js | 3 ++-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> > index 3c15135..3bf5188 100644
> > --- a/www/manager6/Utils.js
> > +++ b/www/manager6/Utils.js
> > @@ -63,6 +63,8 @@ var HostPort_match = new RegExp("^(" + IPV4_REGEXP + "|" +
> > DnsName_REGEXP + ")(:
> >  var HostPortBrackets_match = new RegExp("^\\[(?:" + IPV6_REGEXP + "|" +
> > IPV4_REGEXP + "|" + DnsName_REGEXP + ")\\](:\\d+)?$");
> >  var IP6_dotnotation_match = new RegExp("^" + IPV6_REGEXP + "(\\.\\d+)?$");
> >  
> > +var bus_match = new RegExp("^(ide|sata|virtio|scsi)\\d+$");
> 
> Sorry, but why do we use a global variable here?

I think we should move those things into the 'PVE.Utils' namespace.

@Dominik: same for DocsPages and DocSubTitles