[pve-devel] [PATCH pve-manager] Sort all lists in the storage what we load dynamically.

Dominik Csapak d.csapak at proxmox.com
Wed Oct 5 16:53:05 CEST 2016


looks good

On 10/05/2016 02:27 PM, Wolfgang Link wrote:
> It locks better if the lists are sorted.
> Also if you have long list it makes working easier.
> ---
>  www/manager6/storage/GlusterFsEdit.js | 2 ++
>  www/manager6/storage/IScsiEdit.js     | 2 ++
>  www/manager6/storage/LVMEdit.js       | 4 ++++
>  www/manager6/storage/LvmThinEdit.js   | 2 ++
>  www/manager6/storage/NFSEdit.js       | 2 ++
>  www/manager6/storage/ZFSPoolEdit.js   | 2 ++
>  6 files changed, 14 insertions(+)
>
> diff --git a/www/manager6/storage/GlusterFsEdit.js b/www/manager6/storage/GlusterFsEdit.js
> index 5640da8..3a04fb4 100644
> --- a/www/manager6/storage/GlusterFsEdit.js
> +++ b/www/manager6/storage/GlusterFsEdit.js
> @@ -47,6 +47,8 @@ Ext.define('PVE.storage.GlusterFsScan', {
>  	    }
>  	});
>
> +	store.sort('volname', 'ASC');
> +
>  	Ext.apply(me, {
>  	    store: store
>  	});
> diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js
> index 8ed6218..fdcbfbc 100644
> --- a/www/manager6/storage/IScsiEdit.js
> +++ b/www/manager6/storage/IScsiEdit.js
> @@ -46,6 +46,8 @@ Ext.define('PVE.storage.IScsiScan', {
>  	    }
>  	});
>
> +	store.sort('target', 'ASC');
> +
>  	Ext.apply(me, {
>  	    store: store
>  	});
> diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
> index e409d89..8b7607b 100644
> --- a/www/manager6/storage/LVMEdit.js
> +++ b/www/manager6/storage/LVMEdit.js
> @@ -21,6 +21,8 @@ Ext.define('PVE.storage.VgSelector', {
>  	    }
>  	});
>
> +	store.sort('vg', 'ASC');
> +
>  	Ext.apply(me, {
>  	    store: store,
>  	    listConfig: {
> @@ -71,6 +73,8 @@ Ext.define('PVE.storage.BaseStorageSelector', {
>
>  	store.loadData([{ storage: '' }], true);
>
> +	store.sort('storage', 'ASC');
> +
>  	Ext.apply(me, {
>  	    store: store
>  	});
> diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storage/LvmThinEdit.js
> index a119e5a..d4c89ae 100644
> --- a/www/manager6/storage/LvmThinEdit.js
> +++ b/www/manager6/storage/LvmThinEdit.js
> @@ -43,6 +43,8 @@ Ext.define('PVE.storage.TPoolSelector', {
>  	    }
>  	});
>
> +	store.sort('lv', 'ASC');
> +
>  	Ext.apply(me, {
>  	    store: store,
>  	    listConfig: {
> diff --git a/www/manager6/storage/NFSEdit.js b/www/manager6/storage/NFSEdit.js
> index d435215..20ba83b 100644
> --- a/www/manager6/storage/NFSEdit.js
> +++ b/www/manager6/storage/NFSEdit.js
> @@ -47,6 +47,8 @@ Ext.define('PVE.storage.NFSScan', {
>  	    }
>  	});
>
> +	store.sort('path', 'ASC');
> +
>  	Ext.apply(me, {
>  	    store: store
>  	});
> diff --git a/www/manager6/storage/ZFSPoolEdit.js b/www/manager6/storage/ZFSPoolEdit.js
> index d26eb67..01bc4f6 100644
> --- a/www/manager6/storage/ZFSPoolEdit.js
> +++ b/www/manager6/storage/ZFSPoolEdit.js
> @@ -24,6 +24,8 @@ Ext.define('PVE.storage.ZFSPoolSelector', {
>  	    }
>  	});
>
> +	store.sort('pool', 'ASC');
> +
>  	Ext.apply(me, {
>  	    store: store
>  	});
>





More information about the pve-devel mailing list