[pve-devel] [PATCH storage v2 2/4] correct regression test for sandisk ssds

[Dominik Csapak]

in my initial patch series for the regression test, i failed to notice
the missing attributes for the sandisk ssds (which had not been parsed)

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
changes to v1:
* threshold is now 0 instead of ---
 test/disk_tests/ssd_smart/disklist_expected.json  |   2 +-
 test/disk_tests/ssd_smart/sdd_smart_expected.json | 248 +++++++++++++++++++++-
 2 files changed, 245 insertions(+), 5 deletions(-)

diff --git a/test/disk_tests/ssd_smart/disklist_expected.json b/test/disk_tests/ssd_smart/disklist_expected.json
index f00717f..2eab675 100644
--- a/test/disk_tests/ssd_smart/disklist_expected.json
+++ b/test/disk_tests/ssd_smart/disklist_expected.json
@@ -50,7 +50,7 @@
 	"serial" : "000000000000",
 	"vendor" : "ATA",
 	"journals" : 0,
-	"wearout" : "N/A",
+	"wearout" : "100",
 	"health" : "PASSED",
 	"devpath" : "/dev/sdd",
 	"model" : "SanDisk SD8SB8U1T001122",
diff --git a/test/disk_tests/ssd_smart/sdd_smart_expected.json b/test/disk_tests/ssd_smart/sdd_smart_expected.json
index 99175d8..a85e7d7 100644
--- a/test/disk_tests/ssd_smart/sdd_smart_expected.json
+++ b/test/disk_tests/ssd_smart/sdd_smart_expected.json
@@ -1,14 +1,254 @@
 {
     "attributes" : [
 	{
-	    "id" : "232",
+	    "id" : "  5",
+	    "flags" : "-O--CK",
 	    "fail" : "-",
+	    "worst" : 100,
+	    "raw" : "0",
+	    "threshold" : 0,
+	    "value" : 100,
+	    "name" : "Reallocated_Sector_Ct"
+	},
+	{
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "  9",
+	    "name" : "Power_On_Hours",
+	    "threshold" : 0,
+	    "value" : 100,
+	    "raw" : "799"
+	},
+	{
+	    "name" : "Power_Cycle_Count",
+	    "raw" : "92",
+	    "threshold" : 0,
+	    "value" : 100,
+	    "fail" : "-",
+	    "worst" : 100,
+	    "id" : " 12",
+	    "flags" : "-O--CK"
+	},
+	{
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "165",
+	    "name" : "Unknown_Attribute",
+	    "threshold" : 0,
+	    "value" : 100,
+	    "raw" : "9699447"
+	},
+	{
+	    "value" : 100,
+	    "threshold" : 0,
+	    "raw" : "1",
+	    "name" : "Unknown_Attribute",
+	    "flags" : "-O--CK",
+	    "id" : "166",
+	    "worst" : 100,
+	    "fail" : "-"
+	},
+	{
+	    "id" : "167",
+	    "flags" : "-O--CK",
+	    "fail" : "-",
+	    "worst" : 100,
+	    "raw" : "46",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "name" : "Unknown_Attribute"
+	},
+	{
+	    "name" : "Unknown_Attribute",
+	    "raw" : "5",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "fail" : "-",
+	    "worst" : 100,
+	    "id" : "168",
+	    "flags" : "-O--CK"
+	},
+	{
+	    "flags" : "-O--CK",
+	    "id" : "169",
+	    "worst" : 100,
+	    "fail" : "-",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "raw" : "1079",
+	    "name" : "Unknown_Attribute"
+	},
+	{
+	    "raw" : "0",
+	    "threshold" : 0,
+	    "value" : 100,
+	    "name" : "Unknown_Attribute",
+	    "id" : "170",
+	    "flags" : "-O--CK",
+	    "fail" : "-",
+	    "worst" : 100
+	},
+	{
+	    "fail" : "-",
+	    "worst" : 100,
+	    "id" : "171",
+	    "flags" : "-O--CK",
+	    "name" : "Unknown_Attribute",
+	    "raw" : "0",
+	    "value" : 100,
+	    "threshold" : 0
+	},
+	{
+	    "name" : "Unknown_Attribute",
+	    "raw" : "0",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "fail" : "-",
+	    "worst" : 100,
+	    "id" : "172",
+	    "flags" : "-O--CK"
+	},
+	{
+	    "name" : "Unknown_Attribute",
+	    "threshold" : 0,
+	    "value" : 100,
+	    "raw" : "1",
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "173"
+	},
+	{
+	    "name" : "Unknown_Attribute",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "raw" : "22",
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "174"
+	},
+	{
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "184",
+	    "name" : "End-to-End_Error",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "raw" : "0"
+	},
+	{
+	    "name" : "Reported_Uncorrect",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "raw" : "0",
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "187"
+	},
+	{
+	    "name" : "Command_Timeout",
+	    "raw" : "0",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "fail" : "-",
+	    "worst" : 100,
+	    "id" : "188",
+	    "flags" : "-O--CK"
+	},
+	{
+	    "threshold" : 0,
+	    "value" : 73,
+	    "raw" : "27 (Min/Max 23/64)",
+	    "name" : "Temperature_Celsius",
+	    "flags" : "-O---K",
+	    "id" : "194",
+	    "worst" : 64,
+	    "fail" : "-"
+	},
+	{
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "199",
+	    "name" : "UDMA_CRC_Error_Count",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "raw" : "0"
+	},
+	{
+	    "name" : "Unknown_SSD_Attribute",
+	    "threshold" : 0,
+	    "value" : 100,
+	    "raw" : "146029805602",
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "230"
+	},
+	{
 	    "raw" : "100",
-	    "flags" : "PO--CK",
 	    "value" : 100,
-	    "worst" : 100,
+	    "threshold" : 4,
 	    "name" : "Available_Reservd_Space",
-	    "threshold" : 4
+	    "id" : "232",
+	    "flags" : "PO--CK",
+	    "fail" : "-",
+	    "worst" : 100
+	},
+	{
+	    "threshold" : 0,
+	    "value" : 100,
+	    "raw" : "1574",
+	    "name" : "Media_Wearout_Indicator",
+	    "flags" : "-O--CK",
+	    "id" : "233",
+	    "worst" : 100,
+	    "fail" : "-"
+	},
+	{
+	    "id" : "234",
+	    "flags" : "-O--CK",
+	    "fail" : "-",
+	    "worst" : 100,
+	    "raw" : "2303",
+	    "value" : 100,
+	    "threshold" : 0,
+	    "name" : "Unknown_Attribute"
+	},
+	{
+	    "fail" : "-",
+	    "worst" : 253,
+	    "id" : "241",
+	    "flags" : "----CK",
+	    "name" : "Total_LBAs_Written",
+	    "raw" : "2111",
+	    "value" : 253,
+	    "threshold" : 0
+	},
+	{
+	    "worst" : 253,
+	    "fail" : "-",
+	    "flags" : "----CK",
+	    "id" : "242",
+	    "name" : "Total_LBAs_Read",
+	    "threshold" : 0,
+	    "value" : 253,
+	    "raw" : "1542"
+	},
+	{
+	    "name" : "Unknown_Attribute",
+	    "value" : 0,
+	    "threshold" : 0,
+	    "raw" : "0",
+	    "worst" : 100,
+	    "fail" : "-",
+	    "flags" : "-O--CK",
+	    "id" : "244"
 	}
     ],
     "type" : "ata",
-- 
2.1.4