[pve-devel] [PATCH pve-manager] check if dir /var/log/pveproxy exists.

[Wolfgang Bumiller]

On Tue, Nov 29, 2016 at 11:46:26AM +0100, Fabian Grünbichler wrote:
> On Thu, Sep 15, 2016 at 01:09:38PM +0200, Dietmar Maurer wrote:
> > 
> > 
> > > On September 15, 2016 at 12:25 PM Wolfgang Link <w.link at proxmox.com> wrote:
> > > 
> > > 
> > > We will check on every start of pveproxy if the logdir are available.
> > > If not we make a new one and give www-data permission to this dir.
> > 
> > And you want to do that with every directory?
> 
> this came up in a bug report with /var/log on tmpfs:
> https://bugzilla.proxmox.com/show_bug.cgi?id=1216
> 
> are there still objections to adding this? I think recreating a needed
> log directory is good behaviour for a service daemon anyway..

Ack.

(But can we just do `if (mkdir(...))` instead of checking with -d?
Checking dirs before creating them is generally a bad style since mkdir
can fail with EEXIST anyway)