[pve-devel] [PATCH] VZDump: die with error if plugin loading fails

[Fabian Grünbichler]

On Thu, Nov 17, 2016 at 07:01:24AM +0100, Dietmar Maurer wrote:
> > It is really hard to review patches without descriptions. Please
> > can you add minimal information?
> 
> Oh, just saw you sent that in a separate mail - please ignore me!

Just as a side note - it makes a lot of sense to include the rationale
behind a patch (or a short version of it) in the commit message itself,
except for very trivial patches or where it is really obvious.  This not
only helps understanding when looking at the code later, but also helps
when reviewing the history of a specific part of the code.

Also, for single patches separate cover letters are IMHO a bit noisy, I
prefer putting any extra remarks that should not be committed in the
summary part of a patch (below the three dashes).

The following example is taken from our developer documentation in the
wiki:

>From 12345abcde Mon Sep 12 00:00:00 2001
From: Git Commiter <some email address>
Date: Fri, 7 Oct 2016 08:30:17 +0200
Subject: [PATCH container 1/2] Fix #1013: this and that

Here is your commit message.
It explains the bugfix and ends after thisline.

---
 ***HERE*** you can write your comments.
 If this is a new version of an old patch, explain your changes here

 src/PVE/Tools.pm | 2 +-

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
(...)