[pve-devel] [PATCH] VZDump: die with error if plugin loading fails
Dietmar Maurer
dietmar at proxmox.com
Thu Nov 17 06:59:54 CET 2016
It is really hard to review patches without descriptions. Please
can you add minimal information?
- What is the purpose?
- Does it solve a bug?
I simply cannot see the reason for this patch?
> On November 16, 2016 at 8:08 PM Stefan Priebe <s.priebe at profihost.ag> wrote:
>
>
> Signed-off-by: Stefan Priebe <s.priebe at profihost.ag>
> ---
> PVE/VZDump.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index a4b40ce..42e34d1 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -191,7 +191,7 @@ foreach my $plug (@pve_vzdump_classes) {
> $plug->import ();
> push @plugins, $plug;
> } else {
> - warn $@;
> + die $@;
> }
> }
> }
> --
> 2.1.4
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
More information about the pve-devel
mailing list