[pve-devel] [PATCH] allow --allow-shrink on RBD resize

[Stefan Priebe - Profihost AG]

Am 16.11.2016 um 21:41 schrieb Alexandre DERUMIER:
> It is usefull if we growing the volume ?

no - but the function is called resize not grow ;-) So i use it also for
shrinking volumes.

> I'm seeing a refused tracker/pr here to disallow --alow-shrink on extend
> 
> http://tracker.ceph.com/issues/15991
> https://github.com/ceph/ceph/pull/9408

Both are closed or marked as refused so i don't think this will change
in the future.

Greets,
Stefan

> ----- Mail original -----
> De: "Stefan Priebe, Profihost AG" <s.priebe at profihost.ag>
> À: "pve-devel" <pve-devel at pve.proxmox.com>
> Envoyé: Mercredi 16 Novembre 2016 20:13:59
> Objet: [pve-devel] [PATCH] allow --allow-shrink on RBD resize
> 
> Signed-off-by: Stefan Priebe <s.priebe at profihost.ag> 
> --- 
> PVE/Storage/RBDPlugin.pm | 2 +- 
> 1 file changed, 1 insertion(+), 1 deletion(-) 
> 
> diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm 
> index 09562fe..eb0c256 100644 
> --- a/PVE/Storage/RBDPlugin.pm 
> +++ b/PVE/Storage/RBDPlugin.pm 
> @@ -602,7 +602,7 @@ sub volume_resize { 
> 
> my ($vtype, $name, $vmid) = $class->parse_volname($volname); 
> 
> - my $cmd = &$rbd_cmd($scfg, $storeid, 'resize', '--size', ($size/1024/1024), $name); 
> + my $cmd = &$rbd_cmd($scfg, $storeid, 'resize', '--allow-shrink', '--size', ($size/1024/1024), $name); 
> run_rbd_command($cmd, errmsg => "rbd resize '$volname' error"); 
> return undef; 
> } 
>