[pve-devel] [PATCH ha-manager] get_pve_lock: allow retrying if pmxcfs is offline

[Thomas Lamprecht]

On 11/15/2016 12:08 PM, Dietmar Maurer wrote:
> # pve cluster filesystem not online
>> -	die "can't create '$lockdir' (pmxcfs not mounted?)\n" if ! -d $lockdir;
>> +	if (! -d $lockdir) {
>> +	    $self->log('err', "can't create '$lockdir' (pmxcfs not mounted?)");
>> +	    return 0;
>> +	}
> You are inside 'eval', so this does not retry anything!

It actually did, I tested it before sending.
The method returns $got_lock at the end, which is 0 and so a retry happens.
But yes this is ugly and depends on side effects, I sent v2.