[pve-devel] [PATCH common] remove duplicate 'set -o pipefail'

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue May 24 10:28:35 CEST 2016


---
this did not break anything, but setting the same option twice is unnecessary.

 src/PVE/Tools.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 8c7f373..42066ee 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -308,7 +308,7 @@ sub run_command {
 		$cmdstr .= $pipe .  join(' ', map { ref($_) ? $$_ : shellquote($_) } @$command);
 		$pipe = ' | ';
 	    }
-	    $cmd = [ '/bin/bash', '-c', "set -o pipefail && $cmdstr" ];
+	    $cmd = [ '/bin/bash', '-c', "$cmdstr" ];
 	} else {
 	    $cmdstr = cmd2string($cmd);
 	}
-- 
2.1.4





More information about the pve-devel mailing list