[pve-devel] [PATCH] add hugepages option v2

[Alexandre DERUMIER]

> I think it's missing maybe some kind of lock when allocate|deallocate 
> hugepages. 
> It should work like locks for storage when create|delete disk 

>>I don't think we need a cluster wide lock. Just use a local lock file. 

yes, local to the host only
(Not sure how to implement that ?)

> PVE::QemuServer::Hugepages ? 

>>OK for me. Or is there more memory related code? If so, we could use 
>>PVE::QemuServer::Memory

we have some sub for dimm management, 
like foreach_dimm, qemu_memory_hotplug

maybe also some numa code could go inside it.
(the numa config generation in config_to_command is quite large too,I would like to refactor it in the future,
 as it share some code with my hugepage code)


----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Jeudi 19 Mai 2016 09:22:55
Objet: Re: [pve-devel] [PATCH] add hugepages option v2

> I think it's missing maybe some kind of lock when allocate|deallocate 
> hugepages. 
> It should work like locks for storage when create|delete disk 

I don't think we need a cluster wide lock. Just use a local lock file. 

> >>I also wonder if we can split the code into a separate file, because 
> >>the file PVE/QemuServer.pm is already quite large? 
> 
> I agree that qemuserver is quite large ;) 
> 
> PVE::QemuServer::Hugepages ? 

OK for me. Or is there more memory related code? If so, we could use 
PVE::QemuServer::Memory?