[pve-devel] [PATCH] add hugepages option v2

[Alexandre DERUMIER]

>>the patch looks good to me, but it is quite big. So I need more time 
>>to test before we can include that in the stable codebase. 

ok ,thanks to have take time to review it.

I think it's missing maybe some kind of lock when allocate|deallocate hugepages.
It should work like locks for storage when create|delete disk




>>I also wonder if we can split the code into a separate file, because 
>>the file PVE/QemuServer.pm is already quite large? 

I agree that qemuserver is quite large ;)

PVE::QemuServer::Hugepages  ?



----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Jeudi 19 Mai 2016 07:15:17
Objet: Re: [pve-devel] [PATCH] add hugepages option v2

Hi Alexandre, 

> vm configuration 
> ---------------- 
> hugepages: (any|2|1024) 

the patch looks good to me, but it is quite big. So I need more time 
to test before we can include that in the stable codebase. 

I also wonder if we can split the code into a separate file, because 
the file PVE/QemuServer.pm is already quite large?