[pve-devel] [RFC pve-common] Add user to run_command

Dietmar Maurer dietmar at proxmox.com
Wed May 18 17:21:51 CEST 2016


I also wonder why we have that afterfork option, and that
$orig_pid checks, because we do not fork at all?

Is that a leftover from old code?

> On May 18, 2016 at 5:10 PM Wolfgang Link <w.link at proxmox.com> wrote:
> 
> 
> I discuss with Wolfgang and we will change some things.
> Set Home Dir.
> Check if setuid and setguid worked.
> Check User.
> 
> So I will send a patch V2.
> 
> We can set the ID back on the end of the function.
> I think this make sense.
> 
> On 05/18/2016 05:00 PM, Dietmar Maurer wrote:
> > And when do you change this back?
> > 
> >> +	POSIX::setuid((getpwnam($user))[2]);
> >> +	POSIX::setgid((getgrnam($user))[3]);
> >> +
> >>  	eval {
> >>  	    local $ENV{LC_ALL} = $lang;
> >>  




More information about the pve-devel mailing list