[pve-devel] [PATCH common] network interfaces code is split into syntax dependent and independent parts

[Igor Vlasenko]

On Wed, May 18, 2016 at 12:42 PM, Dietmar Maurer <dietmar at proxmox.com> wrote:
>> Let us start with the following patch below:
>> It is really short, trivial, passes tests,
> Again, I still see no reason to change that code.
> Simply put your code into a separate sub. We can decide later
> if it is worth to share code.

Ok, let's put that matter for later.
I'll try to maintain that patches locally for a time and let them mature.

In that case, jut one last request on refactoring:
a oneline change s/my/our for $bond_modes.

Signed-off-by: Igor Vlasenko <viy at altlinux.org>
---
 src/PVE/INotify.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm
index c34659f..1a34df1 100644
--- a/src/PVE/INotify.pm
+++ b/src/PVE/INotify.pm
@@ -665,7 +665,7 @@ register_file('active', "/var/log/pve/tasks/active",
           \&write_active_workers);


-my $bond_modes = { 'balance-rr' => 0,
+our $bond_modes = { 'balance-rr' => 0,
            'active-backup' => 1,
            'balance-xor' => 2,
            'broadcast' => 3,
-- 
2.6.5