[pve-devel] [PATCH] cephserver : add systemd support V2

[Alexandre DERUMIER]

- $service = $3 ? "ceph-$1\@$3" : "ceph-$1.target"; 
+ $service = defined($3) ? "ceph-$1\@$3" : "ceph-$1.target";

This should fix my patch


----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "dietmar" <dietmar at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mardi 17 Mai 2016 18:43:11
Objet: Re: [pve-devel] [PATCH] cephserver : add systemd support V2

Ok, 

they are a bug in my patch 

+ if ($service && $service =~ m/^(mon|osd|mds|radosgw)(\.([A-Za-z0-9]{1,32}))?$/) { 
+ $service = $3 ? "ceph-$1\@$3" : "ceph-$1.target"; 


in case of first mon creation, the $service = "mon.0" 

but the "$3 ?" test don't work if value is 0. 

That's why it's return the ceph-mon.target, instead ceph-mon at 0 

I'll rework my patch. 


(.target are used to stop/start all services) 

----- Mail original ----- 
De: "dietmar" <dietmar at proxmox.com> 
À: "Wolfgang Bumiller" <w.bumiller at proxmox.com>, "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Mardi 17 Mai 2016 16:57:29 
Objet: Re: [pve-devel] [PATCH] cephserver : add systemd support V2 

OK, I did a hard reset to the previous commit... 

_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel