[pve-devel] [PATCH manager] fix #979: check always for migrated vm

Dominik Csapak d.csapak at proxmox.com
Fri May 6 08:48:29 CEST 2016


we only checked for grouping attributes for moved vms,
but this is only true in server view

e.g. in pool view the grouping attributes is pool
and the item is not reselected, resulting in a "file not found"
error (it looks for the conf on the wrong node)

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/tree/ResourceTree.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index feecf90..d94a63c 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -266,6 +266,7 @@ Ext.define('PVE.tree.ResourceTree', {
 		    if (item) {
 			// test if any grouping attributes changed
 			// this will also catch migrated nodes
+			// in server view
 			var i, len;
 			for (i = 0, len = groups.length; i < len; i++) {
 			    var attr = groups[i];
@@ -276,6 +277,13 @@ Ext.define('PVE.tree.ResourceTree', {
 			    }
 			}
 
+			// explicitely check for node, since
+			// in some views, node is not a grouping
+			// attribute
+			if (!moved && item.data.node !== olditem.data.node) {
+			    moved = true;
+			}
+
 			// tree item has been updated
 			if ((item.data.text !== olditem.data.text) ||
 			    (item.data.running !== olditem.data.running) ||
-- 
2.1.4





More information about the pve-devel mailing list