[pve-devel] [PATCH manager v3] add undo Zoom Button

[Emmanuel Kasper]

      bytesArr : [
> @@ -108,6 +111,18 @@ Ext.define('PVE.widget.RRDChart', {
>  	}
>  	me.axes[0].setTitle(axisTitle);
>  
> +
> +	me.addTool({
> +	    type: 'minus',
> +	    disabled: true,
> +	    tooltip: gettext('Undo Zoom'),
> +	    handler: function(){
> +		var undoButton = me.interactions[0].getUndoButton();
> +		if (undoButton.handler) {
> +		    undoButton.handler();
> +		}
> +	    }
> +	});

maybe is it possible to have the 'Undo Zoom' text on the button itself ?

text: gettext('Undo Zoom'),

it is a good practise to have a text label on the button itself,
as it clarifies the meaning of the icon in this particular context,
without forcing the user to hunt for labels

( this is discussed at length here:
https://www.nngroup.com/articles/icon-usability/ )