[pve-devel] [PATCH manager 3/4] fix #944: do not filter by empty array

Dominik Csapak d.csapak at proxmox.com
Mon May 2 15:43:58 CEST 2016


we set the pveNodeSelector to [] by default,
but filter by !node (![] == false), so that no vms are shown

this occurs, when the pveNodeSelector store loads after the store
for the vm list, which rarely happens

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/dc/Backup.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 14aee2d..6f42ac3 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -264,7 +264,7 @@ Ext.define('PVE.dc.BackupEdit', {
 		    var node = nodesel.getValue();
 		    store.clearFilter();
 		    store.filterBy(function(rec) {
-			return (!node || rec.get('node') === node);
+			return (!node || node.length === 0 || rec.get('node') === node);
 		    });
 		    var list = vmidField.getValue();
 		    var mode = selModeField.getValue();
-- 
2.1.4





More information about the pve-devel mailing list