[pve-devel] [PATCH] Change zfs path when link clone are used

Dietmar Maurer dietmar at proxmox.com
Tue Mar 22 09:11:37 CET 2016


comments inline

> The new naming is coherent to Dir plugin.
> 
> So if we make an licked clone the parent will be coded in the path of the
> storage.

s/licked/linked/

I would really like to have regression tests for this. 
Please can you try to assemble some tests.

> ---
>  PVE/Storage/ZFSPoolPlugin.pm | 30 +++++++++++++++++++-----------
>  1 file changed, 19 insertions(+), 11 deletions(-)
> 
> diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
> index 9f76cee..83b6bf7 100644
> --- a/PVE/Storage/ZFSPoolPlugin.pm
> +++ b/PVE/Storage/ZFSPoolPlugin.pm
> @@ -151,7 +151,7 @@ sub path {
>  	    # fixme: we currently assume standard mount point?!
>  	    $path = "/$scfg->{pool}/$volname";

why not "/$scfg->{pool}/$name" ?

>  	} else {
> -	    $path = "/dev/zvol/$scfg->{pool}/$volname";
> +	    $path = "/dev/zvol/$scfg->{pool}/$name";
>  	}




More information about the pve-devel mailing list