[pve-devel] [PATCH pve-manager] Do not turn the strings CT and VM into separate localizable strings

Dietmar Maurer dietmar at proxmox.com
Mon Mar 21 16:19:26 CET 2016


see comments inline:

> as it happens, even the translators of non-latin alphabet languages
> always leave those intact in their translations
> ---
>  www/manager6/lxc/CmdMenu.js  | 8 ++++----
>  www/manager6/qemu/CmdMenu.js | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/www/manager6/lxc/CmdMenu.js b/www/manager6/lxc/CmdMenu.js
> index 8758bd4..1b9c7a0 100644
> --- a/www/manager6/lxc/CmdMenu.js
> +++ b/www/manager6/lxc/CmdMenu.js
> @@ -27,7 +27,7 @@ Ext.define('PVE.lxc.CmdMenu', {
>  	    });
>  	};
>  
> -	me.title = gettext('CT') + ' ' + vmid;
> +	me.title = 'CT ' + vmid;

Yes, this is OK.

>  
>  	me.items = [
>  	    {
> @@ -53,7 +53,7 @@ Ext.define('PVE.lxc.CmdMenu', {
>  		text: gettext('Suspend'),
>  		icon: '/pve2/images/forward.png',
>  		handler: function() {
> -		    var msg = Ext.String.format(gettext("Do you really want to suspend
> {0}?"), gettext('CT') + ' ' + vmid);
> +		    var msg = Ext.String.format(gettext("Do you really want to suspend CT
> {0}?"), vmid);


I thought about this instead:

    var msg = Ext.String.format(gettext("Do you really want to suspend {0}?"),
'CT' + ' ' + vmid);

Or is this a problem with LTR languages?




More information about the pve-devel mailing list