[pve-devel] [PATCH qemu-server 1/2] clanup: qemu_drive_options is only used inside the one function

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Mar 18 11:42:32 CET 2016


and it doesn't contain 'bootindex'
---
 PVE/QemuServer.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c936f64..b20c63f 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1294,7 +1294,6 @@ sub get_initiator_name {
     return $initiator;
 }
 
-my @qemu_drive_options = qw(heads secs cyls trans media format cache snapshot rerror werror aio discard iops iops_rd iops_wr iops_max iops_rd_max iops_wr_max serial);
 sub print_drive_full {
     my ($storecfg, $vmid, $drive) = @_;
 
@@ -1317,8 +1316,8 @@ sub print_drive_full {
    }
 
     my $opts = '';
+    my @qemu_drive_options = qw(heads secs cyls trans media format cache snapshot rerror werror aio discard iops iops_rd iops_wr iops_max iops_rd_max iops_wr_max serial);
     foreach my $o (@qemu_drive_options) {
-	next if $o eq 'bootindex';
 	$opts .= ",$o=$drive->{$o}" if $drive->{$o};
     }
 
-- 
2.1.4





More information about the pve-devel mailing list