[pve-devel] [PATCH v2 3/3] Allow migrate-all button on HA enabled VMs

[Thomas Lamprecht]

On 17.03.2016 14:12, Caspar Smit wrote:
> 2016-03-17 14:04 GMT+01:00 Thomas Lamprecht <t.lamprecht at proxmox.com
> <mailto:t.lamprecht at proxmox.com>>:
> 
>     Sorry wrote that other mail from mobile and as it seems it should search
>     another mail client, the current one doesn't know to quote.
> 
>     I know that it's not ideal behaviour all the time but we hadn't any good
>     idea how to solve that (with a small simple nice patch) for the HA
>     stack.
>     But limiting (or expanding) the max_workers settings to match your setup
>     is always a good idea so its a reasonable "workaround".
> 
> 
> I tested with the max_workers set to 1 in my datacenter.cfg and now the
> migrateall task still says taks OK fairly quickly but the actual
> migrations now take place 1 at a time which is fine by me :)
> 

The command to migrate a HA resource (ha-manager migrate vm:100) only
queues this for the CRM by appending it to the crm_command file, so
it'll come back with "OK" as soon as that was done, which is almost instant.
The LRM spawns then the actual migration when the CRM picked up the command.

So there can happen two migrations at the same time (even with
max_worker settings), we could sort the list so that HA managed VMs are
processed at last, this would fix that but I'm not sure if its worth it. :)

> I also noticed the max_workers setting is not configurable in the GUI
> (Under Datacenter->Options) would that be a wanted feature i could
> implement and create a patch for?
> 

I would find that great, although I'm not the one deciding that, but as
it's not a big addition or cluttering the GUI I think it'll be accepted.

> 
>     btw. I picked your patch series up in my queue and will send a pull
>     request, did you already signed and sent our CLA? - as mentioned
>     previously this is needed to protect you and us legal wise, before that
>     isn't done we cannot include those patches, I'm afraid.
> 
> 
> Yes, i signed and mailed the CLA 3 days ago and received a confirmation
> from your office.
>  
> 

OK, roger that.

cheers,
Thomas