[pve-devel] [PATCH manager 2/4] ext6migrate: remove unecessary hacks

Dominik Csapak d.csapak at proxmox.com
Mon Mar 14 16:22:33 CET 2016


this removes the two overrides for extjs4

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
i tested much, but did not find any case where these
two hacks are necessary anymore, but if somebody
finds something that does not work anymore,
please send a message, and we should check if we can avoid
these hacks, otherwise we have to re-add them

 www/manager6/Toolkit.js | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/www/manager6/Toolkit.js b/www/manager6/Toolkit.js
index ff59a55..0976fb1 100644
--- a/www/manager6/Toolkit.js
+++ b/www/manager6/Toolkit.js
@@ -97,21 +97,6 @@ Ext.apply(Ext.form.field.VTypes, {
     pveMailText: gettext('This field should be an e-mail address in the format "user at example.com"'),
 });
 
-// we dont want that a displayfield set the form dirty flag! 
-Ext.override(Ext.form.field.Display, {
-    isDirty: function() { return false; }
-});
-
-// hack: ExtJS does not display the correct value if we
-// call setValue while the store is loading, so we need
-// to call it again after loading
-Ext.override(Ext.form.field.ComboBox, {
-    onLoad: function() {
-	this.setValue(this.value, false);
-        this.callOverridden(arguments);
-    }
-});
-
 // ExtJs 5-6 has an issue with caching
 // see https://www.sencha.com/forum/showthread.php?308989
 Ext.define('PVE.UnderlayPool', {
-- 
2.1.4





More information about the pve-devel mailing list