[pve-devel] [PATCH common 1/2] Introduce __snapshot_create_vol_snapshots_hook

Fabian Grünbichler f.gruenbichler at proxmox.com
Mon Mar 7 12:38:37 CET 2016


This hook runs before and after creating volume snapshots,
as well as after unfreezing. Only needed for Qemu right now,
so the base case in PVE::AbstractConfig is a noop.
---
 src/PVE/AbstractConfig.pm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm
index be6eb5c..277434d 100644
--- a/src/PVE/AbstractConfig.pm
+++ b/src/PVE/AbstractConfig.pm
@@ -221,6 +221,14 @@ sub __snapshot_freeze {
     die "abstract method - implement me\n";
 }
 
+# Code run before and after creating all the volume snapshots
+# base: noop
+sub __snapshot_create_vol_snapshots_hook {
+    my ($class, $vmid, $snap, $running, $hook) = @_;
+
+    return;
+}
+
 # Create the volume snapshots for the VM/CT.
 sub __snapshot_create_vol_snapshot {
     my ($class, $vmid, $vs, $volume, $snapname) = @_;
@@ -413,6 +421,8 @@ sub snapshot_create {
 	    $class->__snapshot_freeze($vmid, 0);
 	}
 
+	$class->__snapshot_create_vol_snapshots_hook($vmid, $snap, $running, "before");
+
 	$class->__snapshot_foreach_volume($snap, sub {
 	    my ($vs, $volume) = @_;
 
@@ -423,9 +433,11 @@ sub snapshot_create {
     my $err = $@;
 
     if ($running) {
+	$class->__snapshot_create_vol_snapshots_hook($vmid, $snap, $running, "after");
 	if ($freezefs) {
 	    $class->__snapshot_freeze($vmid, 1);
 	}
+	$class->__snapshot_create_vol_snapshots_hook($vmid, $snap, $running, "after-unfreeze");
     }
 
     if ($err) {
-- 
2.1.4





More information about the pve-devel mailing list