[pve-devel] [PATCH manager 2/2] vzdump: make exclude-path from config file work again

[Jean-Francois Dagenais]

> On Mar 3, 2016, at 03:22, Wolfgang Bumiller <w.bumiller at proxmox.com> wrote:
> 
> Call split_args() on the 'exclude-path' option read from
> /etc/vzdump.conf
> 
> With the move to the generic JSONSchema::parse_config() in
> commit 16145cba the call to split_args() for 'exclude-path'
> was dropped breaking the 'exclude-path' option.
> ---
> PVE/VZDump.pm | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index 7dc4dd0..937d896 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -344,6 +344,9 @@ sub read_vzdump_defaults {
> 
>     my $conf_schema = { type => 'object', properties => $confdesc, };
>     my $res = PVE::JSONSchema::parse_config($conf_schema, $fn, $raw);
> +    if (my $excludes = $res->{'exclude-path'}) {
> +	$res->{'exclude-path'} = PVE::Tools::split_args($excludes);
> +    }
> 
>     foreach my $key (keys %$defaults) {
> 	$res->{$key} = $defaults->{$key} if !$res->{$key};
> --
> 2.1.4
> 
> 

This indeed gets rid of the "strict refs" error, but there's something left...

Contrary to the docs (wiki, man page, etc.), the '/dir/.+' notation doesn't seem
to work here. If I put these instead in vzdump.conf: '/dir/*' then it works.

Same goes for rsync. I tested rsync separately at the cmd line.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20160303/40247bdf/attachment.sig>