[pve-devel] [PATCH cluster 2/2] avoid undefined quorate value on startup

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jun 30 17:20:47 CEST 2016


Oh, yes you are right, that's not needed.


On 06/30/2016 05:17 PM, Dietmar Maurer wrote:
> cfs_status is defined as static value:
>
>   static cfs_status_t cfs_status;
>
> AFAIK such values are always initialized with zero? So this
> is 0 by default, and your patch is not required?
>
>> There's a small timespan where cfs_status.quorate is undefined,
>> from the cfs_status_init() call in pmxcfs until either call
>> cfs_set_quorate directly in pmxcfs.c as we are in local mode
>> or the first quorum notification callback sets it.





More information about the pve-devel mailing list