[pve-devel] [PATCH storage v2 1/2] add Diskmanage Utilities

[Dietmar Maurer]

> +sub init_disk {
> +    my ($disk, $uuid) = @_;
> +
> +    die "not a valid disk" if $disk !~ m|^/dev/| ||  ! -b $disk;
> +
> +    # we should already have checked if it is in use in the api call
> +    # but we check again for safety
> +    die "disk $disk is already in use\n" if disk_is_used($disk);
> +
> +    my $id = $uuid || 'R';
> +    eval {
> +	run_command([$SGDISK, $disk, '-U', $id]);
> +    };
> +    die "ERROR: $@" if $@;

What is the purpose of this eval{}/die ? Prefix the message with 'ERROR'?

> +}
> +
> +sub disk_is_used {
> +    my ($disk) = @_;
> +
> +    my $dev = $disk;
> +    $dev =~ s|^/dev/||;
> +
> +    my $disklist = get_disks($dev);
> +
> +    die "'$disk' is not a valid local disk\n" if !defined($disklist->{$dev});
> +    return 1 if $disklist->{$dev}->{used};
> +
> +    return 0;
> +}
> +
> +sub get_smart_data {
> +    my ($disk) = @_;
> +
> +    die "not a device" if $disk !~ m|^/dev/|;
> +    my $smartdata = {};
> +    my $datastarted = 0;
> +
> +    eval {
> +	run_command([$SMARTCTL, '-a', '-f', 'brief', $disk], outfunc => sub{
> +	    my ($line) = @_;
> +
> +	    if ($datastarted && $line =~ m/^[ \d]{2}\d/) {
> +		$line = trim($line);
> +		my @data = split /\s+/, $line;
> +		my $entry = {};
> +		$entry->{name} = $data[1];
> +		$entry->{flags} = $data[2];
> +		$entry->{value} = $data[3];
> +		$entry->{worst} = $data[4];
> +		$entry->{threshold} = $data[5];
> +		$entry->{fail} = $data[6];
> +		$entry->{raw} = $data[7];
> +		$entry->{id} = $data[0];
> +		push @{$smartdata->{attributes}}, $entry;
> +	    } elsif ($line =~ m/self\-assessment test result: (.*)$/) {
> +		$smartdata->{health} = $1;
> +	    } elsif ($line =~ m/Vendor Specific SMART Attributes with Thresholds:/)
> {
> +		$datastarted = 1;
> +	    }
> +	});
> +    };
> +    die "Error getting S.M.A.R.T. data: $@\n" if $@;
> +    $smartdata->{health} = 'UNKOWN' if !defined $smartdata->{health};
> +    return $smartdata;
> +}
> +
> +sub get_smart_health {
> +    my ($disk) = @_;
> +
> +    return "NOT A DEVICE" if $disk !~ m|^/dev/| || ! -b $disk;
> +
> +    my $message = "UNKOWN";
> +
> +    eval {
> +	run_command([$SMARTCTL, '-H', $disk], outfunc => sub{
> +	    my ($line) = @_;
> +
> +	    if ($line =~ m/test result: (.*)$/) {
> +		$message = $1;
> +	    } elsif ($line =~ m/open device: (.*) failed: (.*)$/) {
> +		$message = "FAILED TO OPEN";
> +	    } elsif ($line =~ m/^SMART Disabled/) {
> +		$message = "SMART DISABLED";
> +	    }
> +	});
> +    };
> +
> +    return $message;
> +}
> +
> +sub get_zfs_devices {
> +    my $list = {};
> +    eval {
> +	run_command([$ZPOOL, 'list', '-HLv'], outfunc => sub {
> +	     my ($line) = @_;
> +
> +	     if ($line =~ m|^\t([^\t]+)\t|) {
> +		$list->{$1} = 1;
> +	     }
> +	});
> +    };

Do we really want to ignore all errors (silently)?

> +    return $list;
> +}
> +
> +sub get_lvm_devices {
> +    my $list = {};
> +    eval {
> +	run_command([$PVS, '--noheadings', '--readonly', '-o', 'pv_name'], outfunc
> => sub{
> +	    my ($line) = @_;
> +	    $line = trim($line);
> +	    if ($line =~ m|^/dev/|) {
> +		$list->{$line} = 1;
> +	    }
> +	});
> +    };

same here?

> +    return $list;
> +}
> +
> +sub get_disks {
> +    my ($disk) = @_;
> +    my $disklist = {};
> +
> +    my $fd = IO::File->new("/proc/mounts", "r") ||
> +	die "unable to open /proc/mounts - $!\n";
> +
> +    my $mounted = {};
> +
> +    my $mounts = PVE::ProcFSTools::parse_proc_mounts();
> +
> +    foreach my $mount (@$mounts) {
> +	next if $mount->[0] !~ m|^/dev/|;
> +	$mounted->{abs_path($mount->[0])} = $mount->[1];
> +    };
> +
> +    my $dev_is_mounted = sub {
> +	my ($dev) = @_;
> +	return $mounted->{$dev};
> +    };
> +
> +    my $dir_is_empty = sub {
> +	my ($dir) = @_;
> +
> +	my $dh = IO::Dir->new ($dir);
> +	return 1 if !$dh;
> +
> +	while (defined(my $tmp = $dh->read)) {
> +	    next if $tmp eq '.' || $tmp eq '..';
> +	    $dh->close;
> +	    return 0;
> +	}
> +	$dh->close;
> +	return 1;
> +    };
> +
> +    my $journal_uuid = '45b0969e-9b03-4f30-b4c6-b4b80ceff106';
> +
> +    my $journalhash = {};
> +    dir_glob_foreach('/dev/disk/by-parttypeuuid', "$journal_uuid\..+", sub {
> +	my ($entry) = @_;
> +	my $real_dev = abs_path("/dev/disk/by-parttypeuuid/$entry");
> +	$journalhash->{$real_dev} = 1;
> +    });
> +
> +    my $zfslist = get_zfs_devices();
> +
> +    my $lvmlist = get_lvm_devices();
> +
> +    dir_glob_foreach('/sys/block', '.*', sub {
> +	my ($dev) = @_;
> +	return if defined($disk) && $disk ne $dev;
> +	# whitelisting following devices
> +	# hdX: ide block device
> +	# sdX: sd block device
> +	# vdX: virtual block device
> +	# xvdX: xen virtual block device
> +	# nvmeXnY: nvme devices
> +	# cXnY: cciss devices
> +	return if $dev !~ m@^(h|s|x?v)d[a-z]+$@ &&
> +		  $dev !~ m@^nvme\d+n\d+$@ &&
> +		  $dev !~ m@^c\d+d\d+$@;
> +
> +	my $sysdir = "/sys/block/$dev";
> +
> +	return if ! -d "$sysdir/device";
> +
> +	# we do not want iscsi devices
> +	return if readlink($sysdir) =~ m|host[^/]*/session[^/]*|;
> +
> +	my $size = file_read_firstline("$sysdir/size");
> +	return if !$size;
> +
> +	$size = $size * 512;
> +
> +	my $info = "";
> +	eval {
> +	    run_command([$UDEVADM, 'info', '-n', $dev, '--query', 'all'], outfunc =>
> sub {
> +		my ($line) = @_;
> +		$info .= "$line\n";
> +	    });
> +	};
> +	warn $@ if $@;
> +	return if !$info;
> +
> +	return if $info !~ m/^E: DEVTYPE=disk$/m;
> +	return if $info =~ m/^E: ID_CDROM/m;
> +
> +	# we use this, because some disks are not simply in /dev
> +	# e.g. /dev/cciss/c0d0
> +	my $devpath;
> +	if ($info =~ m/^E: DEVNAME=(\S+)$/m) {
> +	    $devpath = $1;
> +	}
> +	return if !defined($devpath);
> +
> +	my $serial = 'unknown';
> +	if ($info =~ m/^E: ID_SERIAL_SHORT=(\S+)$/m) {
> +	    $serial = $1;
> +	}
> +
> +	my $gpt = 0;
> +	if ($info =~ m/^E: ID_PART_TABLE_TYPE=gpt$/m) {
> +	    $gpt = 1;
> +	}
> +
> +	# detect SSD
> +	my $rpm = -1;
> +	if ($info =~ m/^E: ID_ATA_ROTATION_RATE_RPM=(\d+)$/m) {
> +	    $rpm = $1;
> +	}
> +
> +	# dir/queue/rotational should be 1 for hdd, 0 for ssd
> +	my $type = 'unknown';
> +	my $rotational = file_read_firstline("$sysdir/queue/rotational");
> +
> +	if ($rotational == 0) {
> +	    $type = 'ssd';
> +	    $rpm = 0;
> +	} elsif ($rotational == 1) {
> +	    if ($rpm != -1) {
> +		$type = 'hdd';
> +	    } elsif ($info =~ m/^E: ID_BUS=usb/) {
> +		$type = 'usb';
> +		$rpm = 0;
> +	    }
> +	}
> +
> +	my $wwn = 'unknown';
> +	if ($info =~ m/^E: ID_WWN=(.*)$/m) {
> +	    $wwn = $1;
> +	}
> +
> +	my $vendor = file_read_firstline("$sysdir/device/vendor") || 'unknown';
> +	my $model = file_read_firstline("$sysdir/device/model") || 'unknown';
> +
> +	# we do not need smart data if we check a single disk
> +	# because this functionality is only for disk_is_used
> +	my $health = get_smart_health($devpath) if !defined($disk);
> +
> +	my $used;
> +
> +	$used = 'LVM' if $lvmlist->{$dev};
> +
> +	$used = 'mounted' if &$dev_is_mounted($devpath);
> +
> +	$used = 'ZFS' if $zfslist->{$dev};

Cant we use the partition table to detect zfs disks?