[pve-devel] [PATCH pve-qemu-kvm] Force enable rbd cache for qmrestore v2

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 26 14:30:43 CEST 2016


Hi Eneko,


On 07/26/2016 02:05 PM, Eneko Lacunza wrote:
> Hi Thomas,
>
> El 26/07/16 a las 13:55, Thomas Lamprecht escribió:
>> Hi, first thanks for the contribution! Not commenting on the code 
>> itself but we need a CLA for being able to add your contributions,
>> we use the Harmony CLA, a community-centered CLA for FOSS projects,
>> see 
>> https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
> Thanks, will send this shortly.

Perfect, thanks!

>>
>> Also I would suggest using git format-patch and git send-email for 
>> sending the patch to the mailing list, so it is ensured that it can 
>> be applied here without problems.
>> A small example of the necessary commands can be found at 
>> https://pve.proxmox.com/wiki/Developer_Documentation#Git_commands_summary
>>
> I saw that, but in this case the modified vma.c file is in a tarball 
> in the git repository, how to proceed in this case? The output sent is 
> created by quilt diff command. :)
>

Ah okay I understand. I'd do the following, the patches from our side 
which make upstream qemu a PVE qemu reside in 
<pve-qemu-kvm-git-folder>/debian/patches/
In the "pve" folder are feature and fixes patches from us and in the 
"extra" folder are mostly security fixes which aren't in upstream yet.

So your patch would go into the pve folder, add a patch file there and 
add it in <pve-qemu-kvm-git-folder>/debian/patches/series file, e.g.:

if you add pve/force-enable-rbd-cache-for-qmrestore.patch

a line with:

pve/force-enable-rbd-cache-for-qmrestore.patch

Should be added to the "series" file.

It's a bit complicated, I know...
Personally I do not use quilt at all but use an standard qemu repo with 
our patches applied on top on separate branches, this way I can do all 
the patchwork with git (which I'm used to).
But I do not think that that would make your case easier... :)

If you say it's just to tiresome/complicated for now I maybe can help 
you and add a commit with a "Signed-off by Eneko Lacunza" line in there, 
so that copyrigth and commit attribution is correctly handled :)

cheers,
Thomas



More information about the pve-devel mailing list