[pve-devel] [PATCH manager] fix influxdb field assignment and allow non integer field

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Jul 26 13:59:39 CEST 2016


On Tue, Jul 26, 2016 at 11:53:29AM +0200, Dominik Csapak wrote:
> this patch fixes an issue where we assemble the influxdb
> key value pairs to the wrong measurement
> 
> and also we did only allow integer fields,
> excluding all cpu,load and wait measurements
> 
> this patch fixes both issues with a rewrite of the
> recursive build_influxdb_payload sub
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---

could you split this into two (or more) parts? mixing cosmetic changes
like variable renaming and style fixes with actual changes makes it hard
to read (and is also bad for git blameability ;)) if the two issues are
easily split into their own commits that might make sense as well



More information about the pve-devel mailing list