[pve-devel] [PATCH ha-manager 1/7] sort some more keys for regression test determinism

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 14 14:41:47 CEST 2016


Else i run in problems with later introduced regression tests

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 src/PVE/HA/Manager.pm    | 2 +-
 src/PVE/HA/NodeStatus.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 1208720..b6b612d 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -417,7 +417,7 @@ sub manage {
 
 	# handle fencing
 	my $fenced_nodes = {};
-	foreach my $sid (keys %$ss) {
+	foreach my $sid (sort keys %$ss) {
 	    my $sd = $ss->{$sid};
 	    next if $sd->{state} ne 'fence';
 
diff --git a/src/PVE/HA/NodeStatus.pm b/src/PVE/HA/NodeStatus.pm
index 632dbd4..4574709 100644
--- a/src/PVE/HA/NodeStatus.pm
+++ b/src/PVE/HA/NodeStatus.pm
@@ -142,7 +142,7 @@ sub update {
 	}
     }
 
-    foreach my $node (keys %{$self->{status}}) {
+    foreach my $node (sort keys %{$self->{status}}) {
 	my $d = $node_info->{$node};
 	next if $d && $d->{online};
 
-- 
2.1.4




More information about the pve-devel mailing list