[pve-devel] [PATCH manager 2/2] add HostList validator and check monhosts with it

Wolfgang Bumiller w.bumiller at proxmox.com
Tue Jul 12 11:32:08 CEST 2016


On Thu, Jul 07, 2016 at 10:48:55AM +0200, Emmanuel Kasper wrote:
> On 07/07/2016 10:39 AM, Emmanuel Kasper wrote:
> >>  // ExtJs 5-6 has an issue with caching
> >> diff --git a/www/manager6/storage/RBDEdit.js b/www/manager6/storage/RBDEdit.js
> >> index a38ea52..a046ec3 100644
> >> --- a/www/manager6/storage/RBDEdit.js
> >> +++ b/www/manager6/storage/RBDEdit.js
> >> @@ -39,6 +39,7 @@ Ext.define('PVE.storage.RBDInputPanel', {
> >>  	    {
> >>  		xtype: me.create ? 'textfield' : 'displayfield',
> >>  		name: 'monhost',
> >> +		vtype: 'HostList',
> >>  		value: '',
> >>  		fieldLabel: gettext('Monitor Host'),
> > 
> > Since we allow here a list of host, can we change the fieldLabel to
> > gettext('Monitor Host(s)') ?
> > 
> > It's confusing when the label Description indicates a single element,
> > but the validation  message indicates a list of elements
> > 
> > This would break here current gettext translations, but three of them
> > (fr, gl, es ) are already false as they interpret Monitor as a verb and
> > not a adjective, ie they translate to something like 'Monitoring the host'.
> > 
> > Besides that some locales translators (de, it) choosed to leave the
> > original string as it is which is here a much better here, so I think
> > dropping here the localized string is OK.
> 
> re reading the Ceph Documentation, 'CEPH Monitor(s)' is maybe the best
> label description.

Or just 'Monitor(s)' since the ceph part should be implied? Not sure.
Can be changed in a separate patch though as this isn't really what the
patch changes (it's been a list from the start after all).



More information about the pve-devel mailing list