[pve-devel] [PATCH manager 2/2] add HostList validator and check monhosts with it

Emmanuel Kasper e.kasper at proxmox.com
Thu Jul 7 10:39:40 CEST 2016


>  // ExtJs 5-6 has an issue with caching
> diff --git a/www/manager6/storage/RBDEdit.js b/www/manager6/storage/RBDEdit.js
> index a38ea52..a046ec3 100644
> --- a/www/manager6/storage/RBDEdit.js
> +++ b/www/manager6/storage/RBDEdit.js
> @@ -39,6 +39,7 @@ Ext.define('PVE.storage.RBDInputPanel', {
>  	    {
>  		xtype: me.create ? 'textfield' : 'displayfield',
>  		name: 'monhost',
> +		vtype: 'HostList',
>  		value: '',
>  		fieldLabel: gettext('Monitor Host'),

Since we allow here a list of host, can we change the fieldLabel to
gettext('Monitor Host(s)') ?

It's confusing when the label Description indicates a single element,
but the validation  message indicates a list of elements

This would break here current gettext translations, but three of them
(fr, gl, es ) are already false as they interpret Monitor as a verb and
not a adjective, ie they translate to something like 'Monitoring the host'.

Besides that some locales translators (de, it) choosed to leave the
original string as it is which is here a much better here, so I think
dropping here the localized string is OK.




More information about the pve-devel mailing list