[pve-devel] [PATCH] Add some extra debug information to the report.

[Wolfgang Bumiller]

On Tue, Jul 05, 2016 at 11:20:02AM +0200, Wolfgang Link wrote:
> There were no useful information about block device.
> ---
>  PVE/Report.pm | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 4d15ef5..99beca2 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -12,7 +12,9 @@ my @general = ('hostname', 'pveversion --verbose', 'cat /etc/hosts', 'top -b -n
>  
>  my @storage = ('cat /etc/pve/storage.cfg', 'pvesm status', 'cat /etc/fstab', 'mount', 'df --human');
>  
> -my @volumes = ('lvdisplay', 'vgdisplay', 'zpool status', 'zfs list');
> +my @volumes = ( "lvs", "vgs';'", 'zpool status', 'zfs list');

What's that ';' part there? (And why break the quoting style).

> +
> +my @disks = ('lsblk', 'multipath-tools -ll', 'multipath-tools -v3');

As far as I can tell the command is just called 'multipath' and
multipath-tools is just the package name.

>  
>  my @machines = ('qm list', sub { dir2text('/etc/pve/qemu-server/', '\d.*conf') });
>  
> @@ -62,7 +64,18 @@ my $bios_report = {
>      commands => \@bios,
>  };
>  
> -my @global_report = ($general_report, $storage_report, $volume_report, $net_report, $cluster_report, $bios_report);
> +my $disks_report = {
> +    title => 'info about teh disks',

s/teh/the/, or just skip the article, the other titles don't use one
either

> +    commands => \@disks,
> +};
> +
> +my $volumes_report = {
> +    title => 'info about the volumes',
> +    commands => \@volumes,
> +};
> +
> +my @global_report = ($general_report, $storage_report, $volume_report, $net_report,
> +		     $cluster_report, $bios_report, $disks_report, $volumes_report);
>  
>  # output the content of all the files of a directory
>  sub dir2text {
> -- 
> 2.1.4