[pve-devel] [PATCH pve-manager] ext6migrate: fix picker dropdown on ViewSelector initial load

Emmanuel Kasper e.kasper at proxmox.com
Wed Jan 27 14:13:00 CET 2016


This fixes a nasty bug where an initial click on the  ViewSelector
trigger would display the picker but hide it immediatly afterwards.

What was happening behind the scene, is that without queryMode 'local',
the store bound to the picker was loaded on each picker display.

Loading the store would then trigger our onLoad() override in ToolKit.js
which called setValue(), which fired a bunch of unwanted events
including 'collapse'.

It is safe here not to call onLoad() to set an initial value, because
the initial value is set in initComponent() (value: groupdef[0][0])
---
 www/manager6/form/ViewSelector.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/form/ViewSelector.js b/www/manager6/form/ViewSelector.js
index 3a80a3d..202c3cc 100644
--- a/www/manager6/form/ViewSelector.js
+++ b/www/manager6/form/ViewSelector.js
@@ -12,6 +12,7 @@ Ext.define('PVE.form.ViewSelector', {
     valueField: 'key',
     displayField: 'value',
     hideLabel: true,
+    queryMode: 'local',
 
     initComponent: function() {
 	var me = this;
-- 
2.1.4





More information about the pve-devel mailing list