[pve-devel] [PATCH pve-manager 3/3] ext6migrate: fix a long running bug where a logout from the GUI would break the workspace

Emmanuel Kasper e.kasper at proxmox.com
Mon Jan 25 15:19:28 CET 2016


If we pass true to the removeAll() , ExtJS6 will try to erase the leafes of a tree,
and then try to to iterate throuch these leaves in onNodeRemove() ( this obviously do not work)

The true parameter does not seem to be needed anyway anymore.
After a call to removeAll, the childNodes[] property of the rootNode is empty
---
 www/manager6/tree/ResourceTree.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index 48c1da6..711a386 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -366,7 +366,7 @@ Ext.define('PVE.tree.ResourceTree', {
 		pdata.updateCount = 0;
 		var rootnode = me.store.getRootNode();
 		rootnode.collapse();
-		rootnode.removeAll(true);
+		rootnode.removeAll();
 		pdata.dataIndex = {};
 		me.getSelectionModel().deselectAll();
 	    },
-- 
2.1.4





More information about the pve-devel mailing list