[pve-devel] [PATCH qemu-server] io throttle: pass pool parameters (*_max)

[Wolfgang Bumiller]

@Alexandre:
I see the additional parameters have been added back in 2013 by you
with commit 74edd76ba:
  qemuserver : iothrottle add support for throttling burst max

Could you check if this was perhaps just forgotten and if it works as
intended with this change?

On Mon, Jan 11, 2016 at 01:27:46PM +0100, Wolfgang Bumiller wrote:

> These have been passed but haven't been used.
> ---
>  PVE/QemuServer.pm | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 77bc501..3a7cb6f 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -4009,11 +4009,26 @@ sub qemu_dimm_list {
>  }
>  
>  sub qemu_block_set_io_throttle {
> -    my ($vmid, $deviceid, $bps, $bps_rd, $bps_wr, $iops, $iops_rd, $iops_wr) = @_;
> +    my ($vmid, $deviceid,
> +	$bps, $bps_rd, $bps_wr, $iops, $iops_rd, $iops_wr,
> +	$bps_max, $bps_rd_max, $bps_wr_max, $iops_max, $iops_rd_max, $iops_wr_max) = @_;
>  
>      return if !check_running($vmid) ;
>  
> -    vm_mon_cmd($vmid, "block_set_io_throttle", device => $deviceid, bps => int($bps), bps_rd => int($bps_rd), bps_wr => int($bps_wr), iops => int($iops), iops_rd => int($iops_rd), iops_wr => int($iops_wr));
> +    vm_mon_cmd($vmid, "block_set_io_throttle", device => $deviceid,
> +	bps => int($bps),
> +	bps_rd => int($bps_rd),
> +	bps_wr => int($bps_wr),
> +	iops => int($iops),
> +	iops_rd => int($iops_rd),
> +	iops_wr => int($iops_wr),
> +	bps_max => int($bps_max),
> +	bps_rd_max => int($bps_rd_max),
> +	bps_wr_max => int($bps_wr_max),
> +	iops_max => int($iops_max),
> +	iops_rd_max => int($iops_rd_max),
> +	iops_wr_max => int($iops_wr_max)
> +    );
>  
>  }
>  
> -- 
> 2.1.4