[pve-devel] [PATCH container 0/5] Further snapshot refactoring

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Feb 23 08:15:07 CET 2016


> Dietmar Maurer <dietmar at proxmox.com> hat am 22. Februar 2016 um 16:15
> geschrieben:
> 
> 
> applied, thanks. But seems you have hardoded line
> numbers inside the test, so they fail after modifying snapshot-test.pm:
> 
> ...
> volume snapshot delete disabled at snapshot-test.pm line 63.
> 
>     #   Failed test '$@ correct'
>     #   at snapshot-test.pm line 130.
>     #          got: 'volume snapshot disabled at snapshot-test.pm line 43.
>     #
>     # '
>     #     expected: 'volume snapshot disabled at snapshot-test.pm line 41.

Yeah, that is a side effect of mocking those methods. I will try to find a
workaround without the line numbers and include it with the rollback tests that
are still on my TODO list.




More information about the pve-devel mailing list