[pve-devel] lasts updates : qemu live migration , missing -machine to target kvm process

[Alexandre DERUMIER]

adding "return $machine" at the end fix the problem for me


sub qemu_machine_pxe { 
my ($vmid, $conf, $machine) = @_; 

$machine = PVE::QemuServer::get_current_qemu_machine($vmid) if !$machine; 

    foreach my $opt (keys %$conf) { 
      next if $opt !~ m/^net(\d+)$/; 
      my $net = PVE::QemuServer::parse_net($conf->{$opt}); 
      next if !$net; 
      my $romfile = PVE::QemuServer::vm_mon_cmd_nocheck($vmid, 'qom-get', path => $opt, property => 'romfile'); 
      return $machine.".pxe" if $romfile =~ m/pxe/; 
      last; 
     } 
  return $machine;
} 


----- Mail original -----
De: "Alexandre Derumier" <aderumier at odiso.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Lundi 22 Février 2016 12:22:41
Objet: Re: [pve-devel] lasts updates : qemu live migration , missing -machine to target kvm process

maybe in migration: 


sub prepare { 

$self->{forcemachine} = PVE::QemuServer::qemu_machine_pxe($vmid, $conf); 


and 

sub qemu_machine_pxe { 
my ($vmid, $conf, $machine) = @_; 

$machine = PVE::QemuServer::get_current_qemu_machine($vmid) if !$machine; 

foreach my $opt (keys %$conf) { 
next if $opt !~ m/^net(\d+)$/; 
my $net = PVE::QemuServer::parse_net($conf->{$opt}); 
next if !$net; 
my $romfile = PVE::QemuServer::vm_mon_cmd_nocheck($vmid, 'qom-get', path => $opt, property => 'romfile'); 
return $machine.".pxe" if $romfile =~ m/pxe/; 
last; 
} 

} 



we return nothing if no pxerom is found 


----- Mail original ----- 
De: "Alexandre Derumier" <aderumier at odiso.com> 
À: "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Lundi 22 Février 2016 12:16:52 
Objet: [pve-devel] lasts updates : qemu live migration , missing -machine to target kvm process 

Hi, 

user have reported a problem with migration from proxmox 4.1 (qemu 2.4) to proxmox 4.1 with last updates (qemu 2.5). 
https://forum.proxmox.com/threads/no-online-migration-possible-to-upgraded-cluster-nodes.26158/ 

I thinked it was a qemu problem, 

but looking at generate qemu command line on target host, 


it's missing the 
-machine pc-i440fx-2.4 param. 


It seem to be a regression, but I don't known when it has been introduced. 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel