[pve-devel] [PATCH] Fix problems with turnkey repository PVE Version 3.4.

Dietmar Maurer dietmar at proxmox.com
Wed Feb 17 15:51:37 CET 2016


comments inline:

> To prevent that one time Net:SSL and an outer time IO::Socket::SSL is loaded,

outer?

> ensure that always use the same socket class.
> 
> We load the the Net:SSL in AccessControl.pm 

where exactly?

> if we call pveupdate,
> but if we call pveam update this module is not loaded an so the default is
> used (IO::Socket::SSL).
> ---
>  PVE/APLInfo.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/PVE/APLInfo.pm b/PVE/APLInfo.pm
> index db32b58..e24f135 100644
> --- a/PVE/APLInfo.pm
> +++ b/PVE/APLInfo.pm
> @@ -252,6 +252,9 @@ sub update {
>      logmsg($logfd, "starting update");
>  
>      import_gpg_keys();
> +    
> +    # ensure that always use the same socket class
> +    local $ENV{PERL_NET_HTTPS_SSL_SOCKET_CLASS} = "IO::Socket::SSL";

But we use the other class in PVE::Subscription.pm:

    local $ENV{PERL_NET_HTTPS_SSL_SOCKET_CLASS} = "Net::SSL";

why?




More information about the pve-devel mailing list